Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExposedThing initialization process not compliant #911

Open
relu91 opened this issue Jan 18, 2023 · 3 comments
Open

ExposedThing initialization process not compliant #911

relu91 opened this issue Jan 18, 2023 · 3 comments
Labels
core Issues with the core library enhancement New feature or request

Comments

@relu91
Copy link
Member

relu91 commented Jan 18, 2023

The Scripting API defines a Expand Thing Init, but currently, our ExposedThing stops at step 3. We should align it with the spec.

p.s. This causes #873, because the HTTP server receives a Thing object without any scheme defined when the CLI module tries to create the Servient Thing using a very simple ExposeThingInit without a security scheme.

@relu91 relu91 added enhancement New feature or request core Issues with the core library labels Jan 18, 2023
@relu91
Copy link
Member Author

relu91 commented Jan 18, 2023

To be precise we sort of implemented some later steps like 8.1, but we are not generating the title automatically. In general, the whole process needs to be reviewed and aligned.

@danielpeintner
Copy link
Member

I think we should also create some tests to confirm that we follow all steps for "expand an ExposedThingInit"

@relu91
Copy link
Member Author

relu91 commented Oct 13, 2023

While solving this issue keep in mind this thread from the PR above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues with the core library enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants