Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): Update Raspberry Pi Example to Jakarta #86

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

AlexCuse
Copy link
Contributor

Use EdgeX 2.1 in examples.

Signed-off-by: Alex Ullrich [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
    - docs change only
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
    - docs change only

Testing Instructions

@AlexCuse AlexCuse linked an issue Jan 24, 2022 that may be closed by this pull request
@AlexCuse AlexCuse force-pushed the main branch 2 times, most recently from 71d0d21 to 247ec22 Compare January 24, 2022 23:33
@AlexCuse AlexCuse changed the title feat(deploy): Update Raspberry Pi Example feat(deploy): Update Raspberry Pi Example to Jakarta Feb 2, 2022
@AlexCuse AlexCuse requested a review from jpwhitemn February 2, 2022 12:12
@AlexCuse
Copy link
Contributor Author

@jpwhitemn @lenny-intel just rebased this - is there anything else needed to get it merged in?

@lenny-goodell
Copy link
Member

@AlexCuse , I will leave this to @jpwhitemn and his team that are familiar with Raspberry PI

@AlexCuse AlexCuse force-pushed the main branch 2 times, most recently from a012f1a to 270886f Compare March 30, 2022 12:24
@AlexCuse
Copy link
Contributor Author

I followed through it this morning to set up a test harness for local go-mod-messaging changes and noticed one header was off and I didn't use a 597* port for the app service. Fixed and rebased the branch while I was at it.

@AlexCuse
Copy link
Contributor Author

AlexCuse commented May 25, 2022

@jpwhitemn I have an example in progress to build a "camera trap" using some cheap GPIO sensors and device-onvif-camera for #87 - do you think this should be added in addition to this example, or as its own thing that assumes some familiarity? It does still provide a sample app and device service but maybe they are a little big to cover in beginner level detail.

bnevis-i
bnevis-i previously approved these changes Jul 25, 2022
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit a follow on PR to upgrade to go 1.18.

@bnevis-i
Copy link
Collaborator

@jpwhitemn This has been sitting out where a while now. Any objections to merging it?

@AlexCuse
Copy link
Contributor Author

AlexCuse commented Aug 2, 2022

I can try to update to 1.18 in this PR that should be pretty quick.

Use EdgeX 2.1 in examples.  Fixes edgexfoundry#76

Signed-off-by: Alex Ullrich <[email protected]>
@AlexCuse
Copy link
Contributor Author

AlexCuse commented Aug 4, 2022

Updated to go 1.18 @bnevis-i. Not doing 2.2 because all my lab stuff is packed for a move and I can't test. Don't really have the interest in going through it again either, I don't know what the holdup has been here but I kind of regret taking it on.

@bnevis-i bnevis-i merged commit 03dc6e4 into edgexfoundry:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Raspberry Pi example to Jakarta and RP4
3 participants