Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device Protocol list in UI #373

Open
jlikeme opened this issue Jun 9, 2021 · 5 comments
Open

Add Device Protocol list in UI #373

jlikeme opened this issue Jun 9, 2021 · 5 comments
Labels
1-low priority denoting isolated changes new feature

Comments

@jlikeme
Copy link

jlikeme commented Jun 9, 2021

Add Device Protocol list in UI, because there will have two or more device protocols in some devices.

@badboy-huaqiao
Copy link
Member

@gao270615179 Good Catch! 👍, that's also our plan not long ago, but due to some irresistible factors we would to do that next version.

But if you have finished that section, we will be very glad to see that your code is committed here.

@badboy-huaqiao badboy-huaqiao added 2-medium priority denoting issues with cross-cutting project impact new feature labels Jun 14, 2021
@badboy-huaqiao
Copy link
Member

badboy-huaqiao commented Apr 14, 2022

After the deeper research and discussion with core team, it doesn't looks like so necessary, what the basis of the conclusion is that which one should be used for device to create the connection at a time. for example, the modbus service supports both RTU and TCP, but only one of them will be used at a time. if there‘s dynamic switching needed, customize your own application.

maybe it should be needed in the future, but now keep that unchanged.

@badboy-huaqiao badboy-huaqiao added 1-low priority denoting isolated changes and removed kamakura 2-medium priority denoting issues with cross-cutting project impact labels Apr 14, 2022
@ajcasagrande
Copy link
Contributor

This feature is useful for the device-onvif-camera service, as right now we utilize the ProtocolProperties as a way to store custom metadata about a device. The problem is that newly discovered devices get both the Onvif and CustomMetadata protocols added, but in the UI only the CustomMetadata shows up:

Screenshot from 2022-07-05 11-22-00

Screenshot from 2022-07-05 11-22-15

@badboy-huaqiao
Copy link
Member

@ajcasagrande that would be great to support multiple device protocols, if we're planing to add new protocol template for device-onvif-camera service (see #531), this feature is required, assign it to me, I will update that.

@ajcasagrande
Copy link
Contributor

@badboy-huaqiao This isn't required for #531 , though it would be nice. The device service will end up adding the missing CustomMetadata protocol I believe. This mostly effects the viewing and editing of existing devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-low priority denoting isolated changes new feature
Projects
None yet
Development

No branches or pull requests

3 participants