Rename environment variable the notebook plugin uses to talk to nbexchange

[agxs]

The notebook plugin uses an environment variable called NAAS_BASE_URL and defaults to https://noteable.edina.ac.uk. This isn't appropriate for a shared plugin as its a bit too Noteable specific, and it's not accurate really.

This variable should be renamed to NBEXCHANGE_BASE_URL and default to http://nbexchange:9000. This is a more accurate name for what the variable is used for.

We need to sync up the noteable-api when this env variable name changes as it's currently passed to notebooks.

[perllaghu]

This appears to have been done:

• The api is using NBEXCHANGE_URL = os.environ.get("NBEXCHANGE_URL", "http://nbexchange:9000")
• The exchange is using self.http_server.listen(self.port, address=self.ip)

[cablesky]

How is the solution?

[ykazakov]

Has this really been addressed? I see only the variable NAAS_BASE_URL and the default value https://noteable.edina.ac.uk:

nbexchange/nbexchange/plugin/exchange.py

Line 31 in 985796a

base_service_url = Unicode(os.environ.get("NAAS_BASE_URL", "https://noteable.edina.ac.uk")).tag(config=True)

[perllaghu]

Has this really been addressed? I see only the variable NAAS_BASE_URL and the default value https://noteable.edina.ac.uk:

nbexchange/nbexchange/plugin/exchange.py

Line 31 in 985796a

base_service_url = Unicode(os.environ.get("NAAS_BASE_URL", "https://noteable.edina.ac.uk")).tag(config=True)

I'm looking at the exchange shortly, and will try and find out what's actually in use.... and make sure the docs match reality