Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PUT for check.request.method in heartbeat http check #41811

Open
shahzad31 opened this issue Nov 27, 2024 · 2 comments
Open

Support PUT for check.request.method in heartbeat http check #41811

shahzad31 opened this issue Nov 27, 2024 · 2 comments
Assignees
@emilioalvap
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@shahzad31
Copy link
Contributor

Describe the enhancement:

We realized we don't support PUT in check.request.method for http check, to fix the issue elastic/kibana#197356

instead of removing it from UI, we can add support for it in the request client, i don't see a reason why we can't.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 27, 2024
@emilioalvap emilioalvap added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed Heartbeat needs_team Indicates that the issue/PR needs a Team:* label labels Nov 28, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@strawgate
Copy link
Contributor

For reference, here's the PR from the last time we added an HTTP method (OPTIONS) to the check
#32987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilioalvap emilioalvap

Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shahzad31 @strawgate @elasticmachine @emilioalvap