-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat] Drop __REALTIME_TIMESTAMP from the output that caused the new field "journald.custom.realtime_timestamp" in the final event document #40658
Conversation
…new field "journald.custom.realtime_timestamp" in the final event document
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@@ -85,4 +85,5 @@ var journaldEventFields = FieldConversion{ | |||
"_SOURCE_REALTIME_TIMESTAMP": ignoredField, // saved in the registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the comment on L84 inaccurate? It also says it is used for the timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it is not accurate, as far as I understand looking at the current code elastic/integrations#10757 (comment)
@belimawr am I missing some place where it is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on L84 was there before we started using journalctl to read the journal. Looking at the old code, the timestamp field was coming from the library we used, here is the code that reads the journal and sets the timestamps.
When I re-wrote it to use journalctl
, I looked at the code and __REALTIME_TIMESTAMP
seemed the best choice to keep the behaviour of the old code/library.
So the comment there might be misleading :/.
I did write a test that compares both implementations reading the same journal file, so I believe the behaviour has not changed with the new implementation.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Proposed commit message
Drop __REALTIME_TIMESTAMP from the output that caused the new field "journald.custom.realtime_timestamp" in the final event document.
This field was not stored before, thus it is not mapped and causes an issue with the 8.16-SNAPSHOT
elastic/integrations#10757
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues