We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signWithParams
No matter what options you have, signWithSignTool always adds hashing/timestampServer params.
signWithSignTool
windows-sign/src/sign-with-signtool.ts
Lines 25 to 31 in 2605684
Then if you signWithParams with the same params (e.g. /td sha256), signing results in error because duplicating params in signtool is not allowed.
/td sha256
signtool
I think this would be good if developers can provide any params in signWithSignTool. Especially because README makes a feeling it is possible:
windows-sign/README.md
Lines 231 to 237 in 2605684
Probably related: Squirrel/Squirrel.Windows#1742
After parsing signWithParams, replace duplicating params.
If this is fine, I'm ready to make a PR.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
No matter what options you have,
signWithSignTool
always adds hashing/timestampServer params.windows-sign/src/sign-with-signtool.ts
Lines 25 to 31 in 2605684
Then if you
signWithParams
with the same params (e.g./td sha256
), signing results in error because duplicating params insigntool
is not allowed.I think this would be good if developers can provide any params in
signWithSignTool
. Especially because README makes a feeling it is possible:windows-sign/README.md
Lines 231 to 237 in 2605684
Probably related: Squirrel/Squirrel.Windows#1742
Proposal
After parsing
signWithParams
, replace duplicating params.If this is fine, I'm ready to make a PR.
The text was updated successfully, but these errors were encountered: