Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Wire up posthog analytics for encryption (same ones which already exist) #25816

Closed
richvdh opened this issue Jul 17, 2023 · 5 comments
Closed

Element-R: Wire up posthog analytics for encryption (same ones which already exist) #25816

richvdh opened this issue Jul 17, 2023 · 5 comments
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@richvdh
Copy link
Member

richvdh commented Jul 17, 2023 •
edited
Loading

I don't really know what's required here. Is anyone (@BillCarsonFr, @pmaier1?) familiar enough with the posthog dashboards to give me any clues about what is expected from the application?

(There's a possibility it will Just Work. But more likely we'll have to re-do some things.)
@richvdh richvdh added T-Enhancement A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Jul 17, 2023
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 26, 2023
@richvdh
Copy link
Member Author

richvdh commented Aug 29, 2023

I think the dashboard we care about is https://posthog.hss.element.io/dashboard/159

@richvdh
Copy link
Member Author

richvdh commented Sep 29, 2023

moving this back to Qualification to get more clarity about what is needed

@BillCarsonFr
Copy link
Member

Fixed by matrix-org/matrix-js-sdk#3710

Now rust throw same decryption errors as legacy (at least for error code relevant to posthog).
The react sdk failure tracker will then report to posthog

@BillCarsonFr
Copy link
Member

=> We should add CryptoModule property in react-sdk for posthog events https://github.com/matrix-org/matrix-analytics-events/blob/2976fe5993204948400290507540af0afff989dd/schemas/Error.json#L35C11-L35C11

@richvdh
Copy link
Member Author

richvdh commented Oct 25, 2023

Closing in favour of #26449

@richvdh richvdh closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @weeman1337 @BillCarsonFr