Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry_options passed to dataloader and ecto #14

Open
arnodirlam opened this issue Jun 22, 2022 · 0 comments
Open

Add telemetry_options passed to dataloader and ecto #14

arnodirlam opened this issue Jun 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@arnodirlam
Copy link
Contributor

arnodirlam commented Jun 22, 2022

Currently, queries run by dataloader happen under the hood without the ability to pass additional options to them.

It should be possible to do this

  1. when calling the Dx API
    Dx.Defd.load!(..., telemetry_options: [...])
  2. globally and dynamically
    config :dx telemetry_options: &MyApp.Dx.Config.telemetry_options/1
    
    defmodule MyApp.Dx.Config do
      def telemetry_options(atom) do
        [
          logger_metadata: Logger.metadata()
        ]
      end
    end
@arnodirlam arnodirlam added the enhancement New feature or request label Jun 22, 2022
@arnodirlam arnodirlam changed the title Allow passing options through to backend query functions Add telemetry_options passed to dataloader and ecto Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant