Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if .git/hooks/pre-commit file exists #16

Open
lcidral opened this issue Mar 7, 2020 · 3 comments
Open

Check if .git/hooks/pre-commit file exists #16

lcidral opened this issue Mar 7, 2020 · 3 comments
Labels
Milestone

Comments

@lcidral
Copy link
Member

lcidral commented Mar 7, 2020

As reported by @amadeu01, there is a possibility of developer has .git/hooks/pre-commit, if so we can't overwrite it, returning an error when running git pair init.

We also, discussed to introduce a script to create a pre-commit file that would iterate over .git/hooks/pre-commits directory then call it script under it (including our git-pair _append-coauthors call). But I think that we should create a separate issue for this one. WDYT?

@lcidral lcidral added the task label Mar 7, 2020
@lcidral lcidral added this to the v1.1.0 milestone Mar 7, 2020
@amadeu01
Copy link
Member

Handling more hooks per trigger seems to be another task outside the scope of the project.
I think if some user already has a hook for pre-commit event trigger, we should let them call the CLI without the hooker.

@amadeu01
Copy link
Member

(We can make another tool for handling more hooks scripts per events )

@wevtimoteo
Copy link
Member

I think we can, initially, consider a separate task for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants