♻️ Refactor Actions to accept email for GitLab #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| @@ -0,0 +1,20 @@ | |||
| defmodule GitPair.Storage do | |||
There was a problem hiding this comment.
Modules should have a @moduledoc tag.
amadeu01
force-pushed
the
ac-wt/accept-user-email-in-add-command
branch
from
bc80fce to
f84a7dc
Compare
added 2 commits
October 6, 2020 21:13
This module will be responsible to coordinate all interactions with `git config` command.
amadeu01
force-pushed
the
ac-wt/accept-user-email-in-add-command
branch
from
f84a7dc to
3675765
Compare
Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: wevtimoteo <[email protected]>
For now, we are only using the `Storage` module for adding users. However, we are planning to refactor `Actions` to remove all `System` calls. Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: wevtimoteo <[email protected]>
|
SourceLevel has finished reviewing this Pull Request and has found:
|
wevtimoteo
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27
Note: