-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format for helm-gtags-parse-file output. #170
base: master
Are you sure you want to change the base?
Conversation
I'm interested in this pull request as well. In the same vein, I added a variable to toggle truncating lines. When using narrower frames, this can help make the buffer look less cluttered. Would you consider adding it to your pull request? 0001-Add-variable-to-truncate-lines-in-helm-gtags-parse-f.txt |
@jomi-se |
Cool ! But the patch doesn't have anything to do with stripping line numbers. It just adds a variable that is passed as helm:truncate-lines so that this value can be easily set only for helm-gtags buffers. What this value does is enable/disable line-wrapping when the line is longer than the frame's width. With helm:truncate-lines at nil, lines wrap around as they do in your first 2 screenshots. With this patch you can customize a variable to truncate these lines instead. |
Rigth. Not it makes sense. |
@jacekmigacz That's a good idea. Looking at the code, most helm-gtags-* functions end up calling
But we could rename this variable to |
With recent helm updates, the helm-gtags-direct-helm-completing is broken. Instead of calling helm-comp-read, completing-read-function is left not overwritten with completing-read-default. |
I'm not sure why is it failing, but looks it is not related with my changes...
|
(match-string-no-properties 2 removed-file) | ||
(match-string-no-properties 3 removed-file))))) | ||
(setq helm-gtags--last-input (match-string 1 removed-file)) | ||
(format "%s:%s:%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the original format ("%-25s %-5s %s") is better-looking than your format here.
Syohei-san.
I think current helm-output of helm-gtags-parse-file is unreadable:
I'm proposing another output format:
Regards.