dynamic_modules: Fix headers in bazel test setup #37427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
|
cc @mathetake |
|
these build target is in C, not C++, so I was thinking just to ignore as in #37426 |
|
i think the problem (iiuc) is that the aspect is visiting this node and seeing the header files as srcs |
|
we may need to ignore stuff anyway - but i suspect this will fix - and its defo the right thing to do (with caveat that im still testing elsewhere and waiting on results) |
mathetake
approved these changes
Nov 29, 2024
|
@mathetake closing ths in favour of #37420 - add this change there |
auto-merge was automatically disabled
November 29, 2024 18:53
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.