Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4v2 deletes all audio content when saving M4A files #45

Open
Openstreetmapler opened this issue Sep 11, 2023 · 3 comments
Open

MP4v2 deletes all audio content when saving M4A files #45

Openstreetmapler opened this issue Sep 11, 2023 · 3 comments

Comments

@Openstreetmapler
Copy link

Openstreetmapler commented Sep 11, 2023

(Original issue reported for Kid3)

MP4v2 Version: the one used as a plugin in Kid3 3.9.3 (probably MP4v2 v2.1.0 or v2.1.1)
This means that the issue might already be fixed in the latest version.

When I edit the tags of an MP4/M4A file that I downloaded from YouTube using kid3 and save them, all audio content gets stripped away. According to Urs Fleisch’s comment, it must be an issue with libmp4v2metadata.dylib.

Steps to reproduce in Kid3

  1. Open an MP4/M4A audio file
  2. Make any changes in the Tag 2: MP4 section
  3. Press the Save button

Observed result

The file doesn't get corrupted, but the audio length becomes zero-duration and the file size shrinks down to a few bytes to kilobytes, i. e. it will only consist of the tags.

Expected result

MP4 tags are written and the audio is untouched.

Software/OS Versions

  • macOS Big Sur 11.6
  • Kid3 3.9.3
  • MP4v2 unknown version, probably 2.1.0 or 2.1.1

Additional information

With Kid3, I can avoid the problem by using TagLib instead of MP4v2. This raises the question: What is TagLib doing differently where MP4v2 fails?

@enzo1982
Copy link
Owner

Thank you for reporting this!

I can reproduce and confirm the issue. It happens with DASH files which are not really supported by MP4v2 yet. Nevertheless, opening such a file, adding tags and storing it should not damage the remaining data.

I'll investigate and report back.

@Openstreetmapler
Copy link
Author

It seems to only happen with some DASH files; for example, this one:

Apollo.LTD.-.Sunday.Morning.Feeling.ft.Ryan.Stevenson.mp4

(Had to change the extension from .m4a to .mp4 so GitHub accepts it.)

@Openstreetmapler
Copy link
Author

Hmm … Did anyone read my comment from 3 days ago?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants