Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review alt text for all figures #112

Closed
Bisaloo opened this issue Aug 26, 2024 · 2 comments · Fixed by #114
Closed

Review alt text for all figures #112

Bisaloo opened this issue Aug 26, 2024 · 2 comments · Fixed by #114

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Aug 26, 2024

No description provided.

@TimTaylor
Copy link
Contributor

Related (could broaden this to an alt-text issue) ...

If you're like me and have been using devtools::build_site() you may be oblivious to many of pkgdowns warnings when building locally (they are suppressed by default). This difference between devtools::build_site() and pkgdown::build_site() may be worth flagging in the blueprints.

r-lib/devtools#2578

@Bisaloo
Copy link
Member Author

Bisaloo commented Sep 10, 2024

Related (could broaden this to an alt-text issue) ...

If you're like me and have been using devtools::build_site() you may be oblivious to many of pkgdowns warnings when building locally (they are suppressed by default). This difference between devtools::build_site() and pkgdown::build_site() may be worth flagging in the blueprints.

r-lib/devtools#2578

A potentially more effective solution would be to surface warnings as errors in the pkgdown CI workflow. But that would inevitably cause more CI failures, which seem to already cause some friction 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants