Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage of additional filesystem types over webgui #532

Open
n1ete opened this issue Jan 3, 2021 · 1 comment
Open

Manage of additional filesystem types over webgui #532

n1ete opened this issue Jan 3, 2021 · 1 comment

Comments

@n1ete
Copy link

n1ete commented Jan 3, 2021

as already mentioned it would be a sweet addition to danube to manage lofs mountpoints for local storagepools for zones!
Zones are awesome on danube/smartos no overhead and full isolation. I use them a lot to run some stateless services for internal and external purpose so i thought it could be nice to manage Mounpoints from danube ui!

To use them over the webinterface would add features that are already working in danube and is just not exposed via gui.
a further read about latest development on vmadm reveals that you can even add and remove delegated datasets after vm creation, without destroying them! thats great news i think.

so i suggest to add these new "add_filesystem" and "remove_filesystem" functionality for all three filesystem types zfs/lofs/disk into Danube. at the moment only "disk" file type is managble over Danube UI and these two new filesystem types would integrate probably very well.

example of a command to add a lofs Filesystem in vmadm looks like this:

"add_filesystems": [
      {
        "type": "lofs",
        "source": "/zones/mailstore",
        "target": "/local/mailstore"
      }
    ]

to remove the same:

"remove_filesystems": [
      {
        "type": "lofs",
        "source": "/zones/mailstore",
        "target": "/local/mailstore"
      }
    ]

maybe the mountpoint sources should be predefined somewhere on node settings (since they are local only availble) and should then be selectable in Machines view per VM. as a surplus goal it would be nice to make the options 'ro' 'nodevice' selectable.
addding a lofs mount source needs a "does source exist" check.
target folder for lofs gets created if it does not exist.

i dont know if i am able to draft a pr for this. maybe you can help and give me some guidance where to start and what to look for.

@YanChii
Copy link
Contributor

YanChii commented Jan 4, 2021

Very nice analysis. I like the idea of reusing the add-disk call. I'll think about it. At first look it should not be that hard to add it at least into API.
I'll let you know.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants