[wip] Close cursor if it's opened by different tx #12546
+334
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awskii maybe we must
|
|
@AskAlexSharov from one side yes, it would be better to panic with info, but i had a small intention to reuse sharedDomains without closing and reopening (requires only to set up new aggtx) but this could end up badly. |
|
|
|
i found it useful while did commitment rebuilding. I am going to add panic as you said. |
awskii
changed the title
AskAlexSharov
approved these changes
Nov 5, 2024
| eface := *(*[2]uintptr)(unsafe.Pointer(&tx)) | ||
| if dt.valsC != nil { // run in assert mode only | ||
| fmt.Printf("cmp e1=%x e2=%x s=%x d=%s\n", eface[0], eface[1], dt.vcParentPtr.Load(), dt.d.filenameBase) | ||
| if !dt.vcParentPtr.CompareAndSwap(eface[1], eface[1]) { // cant swap when parent ptr is different |
There was a problem hiding this comment.
do we need atomic here? sd is not thread-safe
There was a problem hiding this comment.
FYI: tx has method tx.ViewID()
|
this branch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we keep cursor interface opened inside
DomainRoTx. If we then create new tx and try to read with it fromDomainRoTx, value will be fetched via previously opened cursor which is not expected behaviour.I set stupid fix for that but i assume there could be better solutions.