Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonrpc: Refactor top level api methods to separate file #13072

Merged
merged 4 commits into from
Dec 11, 2024
Merged

jsonrpc: Refactor top level api methods to separate file #13072

merged 4 commits into from
Dec 11, 2024
+168 −157

Conversation

somnathb1
Copy link
Contributor

The separate file - engine_api_methods.go created to separate out the top level methods, which also have links to their documents. The main engine_server.go still holds most important bits of logic.

taratorio
taratorio approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@taratorio taratorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however there is a merge conflict with main

@somnathb1 somnathb1 enabled auto-merge (squash) December 11, 2024 13:51
@somnathb1 somnathb1 merged commit db60360 into main Dec 11, 2024
13 checks passed
@somnathb1 somnathb1 deleted the som/refactor_engine_server branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taratorio taratorio taratorio approved these changes

@yperbasis yperbasis Awaiting requested review from yperbasis

@racytech racytech Awaiting requested review from racytech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somnathb1 @taratorio