-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESP32-S3 PowerFeather #8889
Add support for ESP32-S3 PowerFeather #8889
Conversation
Hello @SuGlider, @me-no-dev, @P-R-O-C-H-Y this is my first time adding support for a new board for Arduino (one that I created). I patterned the changes in this PR after other PR's adding support for a new board, and found that they add entries in the I currently have Can you point me in the right direction? |
@P-R-O-C-H-Y ptal :) |
Thanks for the guidance @me-no-dev, much appreciated! I've made most of the changes you suggested, ptal. |
Hi @powerfeatherdev, "This branch has conflicts that must be resolved". Can you please fix it? Also merge the latest changes from |
Hi @P-R-O-C-H-Y, resolved by rebasing to latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @powerfeatherdev, PTAL on my comments.
Fixed @P-R-O-C-H-Y |
Thank you very much @P-R-O-C-H-Y and @me-no-dev ! |
Description of Change
Adds a new
variant
directory foresp32s3_powerfeather
, under which thepins_arduino.h
is created.Entries for
esp32s3_powerfeather
inboards.txt
are added.Tests scenarios
pins_arduino.h
is okboards.txt
entries are okRelated links
Website: https://www.powerfeather.dev/
Allocation for PID under Espressif VID used in this PR: espressif/usb-pids#123