Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

led_indicator features (AEGHB-413) #299

Closed
espzav opened this issue Oct 5, 2023 · 7 comments
Closed

led_indicator features (AEGHB-413) #299

espzav opened this issue Oct 5, 2023 · 7 comments

Comments

@espzav
Copy link
Contributor

espzav commented Oct 5, 2023

Hello,
please, could you help me understand the LED Indicator component? I thought, that it will be similar like iot_button, but it was false.

  1. How can I use LED Indicator component for on/off LED? When I configure LED, it can blink, but I don't know, how can I on of off.
  2. Please, is there a plan to add LED Strip features into this component? Something like ADC support in iot_button?
  3. I wanted to try Breathe effect and I changed default code like this:
static const blink_step_t default_connecting[] = {
    {LED_BLINK_BREATHE, LED_STATE_ON, 800},
    {LED_BLINK_HOLD,    LED_STATE_ON, 200},
    {LED_BLINK_BREATHE, LED_STATE_OFF, 800},
    {LED_BLINK_HOLD,    LED_STATE_OFF, 200},
    {LED_BLINK_LOOP, 0, 0},
};

And it is only changing brightness from zero to 255 and then skip to zero and again from zero to 255. But not changing from 255 to zero. Could you help me please?

It will help with Generic BSP, which I am making now.

Thank you for help.

@github-actions github-actions bot changed the title led_indicator features led_indicator features (AEGHB-413) Oct 5, 2023
@lijunru-hub
Copy link
Contributor

This is a bug that will be fixed in version 0.4.1.

If there are any requirements, please feel free to mention them.

In the future, we will support the WS2812 driver and provide the ability to modify settings. However, it's possible that gradual color fading may not be supported initially.

@espzav
Copy link
Contributor Author

espzav commented Oct 9, 2023

Hi @lijunru-hub,
thank you for the response. Please, do you know, when the version 0.4.1 will be released?

Support of the WS2812 will be good. I used this component https://components.espressif.com/components/espressif/led_strip now and added it in custom config. It is working, but I haven't got API for change color. For the first, there can be function for set color, and after that on/off, blink and fade all channels of brightness in same values.

The last think, there will be nice to change default settings here: https://github.com/espressif/esp-iot-solution/blob/master/components/led/led_indicator/src/led_indicator_blink_default.c to something more independent. For example:

  1. LED_ON
  2. LED_OFF
  3. LED_BLINK_SLOW
  4. LED_BLINK_FAST
  5. LED_BREATHE_SLOW
  6. LED_BREATHE_FAST

Thank you very much!

@espzav
Copy link
Contributor Author

espzav commented Oct 19, 2023

Hi,
FIY: I updated led_strip component for support in IDF4.4, it can help to support RGB inside the led_indicator. Here is PR: espressif/idf-extra-components#253

@lijunru-hub
Copy link
Contributor

@espzav version 0.5.0 will released as soon as possible.

@leeebo
Copy link
Collaborator

leeebo commented Oct 23, 2023

Reopen until led_strip is supported

@leeebo leeebo reopened this Oct 23, 2023
@leeebo
Copy link
Collaborator

leeebo commented Nov 1, 2023

Hi @espzav , the feature has been added to espressif/led_indicator through ee5f4cc. please update to version: 0.6.* to have a try

@leeebo leeebo closed this as completed Nov 1, 2023
@espzav
Copy link
Contributor Author

espzav commented Nov 1, 2023

Hi @leeebo, Thank you very much! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants