Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blacklisted_regex to shhgit #70

Open
marcelo321 opened this issue Oct 22, 2020 · 1 comment
Open

add blacklisted_regex to shhgit #70

marcelo321 opened this issue Oct 22, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@marcelo321
Copy link

As far as I know shhgit supports:

blacklisted_strings, blacklisted_extensions, blacklisted_paths and blacklisted_entropy_extensions.

Would it be possible to add blacklisted_regex so we can properly discard things we don't want? I can do it with grep on the output, but there are side cases, like when there is more than 1 match inside the same file, that one might match the regex (being a false positive) and will also discard the valid finding.

@eth0izzle
Copy link
Owner

Hey @marcelo321. That's a great idea. I don't have to time to work on this myself but feel free to submit a PR and I will gladly merge in.

@eth0izzle eth0izzle added enhancement New feature or request help wanted Extra attention is needed labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants