Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading comments in test filler #1407

Open
xrchz opened this issue Oct 18, 2024 · 1 comment · May be fixed by #1414
Open

Misleading comments in test filler #1407

xrchz opened this issue Oct 18, 2024 · 1 comment · May be fixed by #1414

Comments

@xrchz
Copy link

xrchz commented Oct 18, 2024

; Put a 0x10 byte long value in zero (each byte is two hex digits)

The comments claim a 0x10 byte long value is going into memory, but then the value is 0x11 bytes. I think this may be related to another misleading comment earlier that says an mload should produce 0 when it in fact produces 0x12.

@winsvega
Copy link
Collaborator

winsvega commented Nov 5, 2024

feel free to correct

@DavidRomanovizc DavidRomanovizc linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants