Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resistor-color-trio files #391

Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Sep 1, 2023

In syncing the tests, there's a test to ignore additional colors. Since I had to update example.lua for the additional unit conversions, I also changed decode to take an array. However, I'm fine with changing that part back if we want to mark that test as not included. Although If we want to keep the test, I can do a variable number of arguments like decode(c1, c2, c3, ...) and not break existing student solutions. The solutions will still need to be updated for the additional conversions, but at least it'd be just that part that needs to be updated.

@ryanplusplus
Copy link
Member

Hey @BNAndras, thanks for putting this together! As far as taking an array, I'd prefer to keep taking individual named arguments for the sake of not breaking existing solutions. I don't think that a variable number of arguments is necessary as Lua ignores additional arguments and using 3 named arguments instead of ... is a valid way to pass that test.

@BNAndras
Copy link
Member Author

BNAndras commented Sep 1, 2023

My bad. I confused the warning from the Lua language server about decode only expecting three arguments as an actual error. I'll fix momentarily

@ryanplusplus ryanplusplus merged commit 704adba into exercism:main Sep 2, 2023
2 checks passed
@ryanplusplus
Copy link
Member

My bad. I confused the warning from the Lua language server about decode only expecting three arguments as an actual error. I'll fix momentarily

No worries, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants