You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
'Element(s) matching "' . $selector . '" could not be found within ' . $seconds . ' seconds',
$this->getSession()->getDriver()
);
}
}
The SpinnedMinkSteps method internally uses the default MinkContext::assertElementOnPage method which in turn converts the given CSS selector into XPath and uses XPath to search for the element(s) (note lines 165 to 168):
Do we need both variants (using JavaScript for CSS selection and using the Driver's internal XPath matching ability)? If not, can we remove the WebsiteInteractionSteps method in favor of the spinned variant of MinkContext's default method?
The text was updated successfully, but these errors were encountered:
Actual
Currently, the following two seemingly equivalent methods exist:
WebsiteInteractionSteps::waitForMatchingElementsWithinSpecifiedTime
SpinnedMinkSteps::assertElementOnPageWithinSpecifiedTime
The WebsiteInteractionSteps method uses plain JavaScript (note line 51):
behat-utils/src/WebsiteInteractionSteps.php
Lines 39 to 59 in 17ba18b
The SpinnedMinkSteps method internally uses the default MinkContext::assertElementOnPage method which in turn converts the given CSS selector into XPath and uses XPath to search for the element(s) (note lines 165 to 168):
https://github.com/minkphp/Mink/blob/d5ee350c40baff5f331a05ebdbe1927345c9ac8b/src/Element/Element.php#L151-L169
Points of Discussion
The text was updated successfully, but these errors were encountered: