Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped values in the viewangletox array (angletoxTable.eps) #44

Open
gianlucag opened this issue Apr 7, 2023 · 4 comments
Open

Swapped values in the viewangletox array (angletoxTable.eps) #44

gianlucag opened this issue Apr 7, 2023 · 4 comments

Comments

@gianlucag
Copy link
Contributor

On the angletoxTable.eps picture, shouldn't it be:

viewangletox[1028] = 319
viewangletox[3073] = 0

angletox

@fabiensanglard
Copy link
Owner

Yes, there is a mistake in the drawing. Do you want to send a pull request :) ?

@gianlucag
Copy link
Contributor Author

gianlucag commented Apr 8, 2023

Ok I'll do it. I didn't submit a pull req straight away because I'm not quite familiar with the .eps format. I guess I need to update the .svg as well...

@fabiensanglard
Copy link
Owner

fabiensanglard commented Apr 8, 2023 via email

@gianlucag
Copy link
Contributor Author

gianlucag commented Apr 13, 2023

Done, I pushed the changes and submitted the PR. Please have a look. The .eps looks fine but I got lots of changes inside the file, just by swapping the two values of the array. I don't know if I did it right or not.
The PR includes other fixes for the 3drenderer chapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants