Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Compiler iterates over every file under root when Watchman is disabled #4849

Open
sverrejoh opened this issue Nov 19, 2024 · 0 comments · May be fixed by #4850
Open

Relay Compiler iterates over every file under root when Watchman is disabled #4849

sverrejoh opened this issue Nov 19, 2024 · 0 comments · May be fixed by #4850

Comments

@sverrejoh
Copy link

Relay compiler falls back to using WalkDir to iterate over the filesystem when Watchman isn't available. The problem is that this implementation walks over every single file under root_dir, which can be your entire repository, rather than limiting it to the files being referenced by the Relay configuration.

This can be a lot of wasted work, and is going to be slow for larger mono-repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant