Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect / within values of a multi-value borderRadius shorthand #730

Open
nmn opened this issue Oct 9, 2024 · 0 comments
Open

Detect / within values of a multi-value borderRadius shorthand #730

nmn opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@nmn
Copy link
Contributor

nmn commented Oct 9, 2024

NOTE: This is a very specific, edge-case bug.

When in styleResolution: 'legacy-expand-shorthands', we expand shorthand CSS properties into their constituent longhand properties. This includes borderRadius.

However, when splitting borderRadius, we treat a space separation to imply the next direction. This misses the edge-case that 1px / 2px is a valid value for a single corder when used in a border-radius.

e.g.

borderRadius: '1px / 2px 3px 4px 5px'

should be split into:

borderStartStartRadius: '1px / 2px',
borderStartEndRadius: '3px',
borderEndEndRadius: '4px',
borderEndStartRadius: '4px',
@nmn nmn added the bug Something isn't working label Oct 9, 2024
@nmn nmn self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant