Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint Github Action #382

Open
crasanders opened this issue Sep 8, 2024 · 0 comments
Open

Improve lint Github Action #382

crasanders opened this issue Sep 8, 2024 · 0 comments

Comments

@crasanders
Copy link
Contributor

Our Github action is supposed to perform linting but it's not configured correctly. Our code should be formatted using flake8 and black, and type-checked with mypy, but only the mypy checking is working correctly. flake8 warnings are being suppressed, and black isn't being used at all.

See the botorch workflows for an example of how this could work: https://github.com/pytorch/botorch/blob/main/.github/workflows/lint.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant