Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources and Speed #26

Open
patel8786 opened this issue Aug 31, 2020 · 1 comment
Open

Resources and Speed #26

patel8786 opened this issue Aug 31, 2020 · 1 comment
Labels
T: enhancement Enhancement.

Comments

@patel8786
Copy link

Firstly, THANK YOU!

Now, my problem. I'm currently running this on a 1GB file. It's been running for over an hour and is using 13GB RAM (I've got 20GB)
Even with smaller files it can be quite time consuming.

I know that it may require a significant rewrite to make it more efficient but it would be nice if it at least only did the viewable lines instead of the whole file

Thanks again 👍

@gir-bot gir-bot added the S: triage Issue needs triage. label Aug 31, 2020
@facelessuser
Copy link
Owner

Unfortunately, this is just a limitation of the plugin.

  1. Sublime does not offer us the line endings. I can't just inspect the text in a window of the view.
    I have to read the content from storage. So we just read the whole file.

  2. Sublime's phantom creation may take a bit more time than just inserting plain text, but it also ensures we never confuse real text with our tokens.

  3. While I can see the desire to run this on large files, it is not designed to do so, and since
    it is not really easy to chunk the content through the Sublime API, it is what it is.

The bigger the file, the longer it takes to render. FWIW, I think RawLineEdit fulfills most of my needs. I'm open to anyone willing to put it in the time to make it more efficient, but for as often as I use it (which isn't very often) there just isn't motivation for me to do that work at this time.

@gir-bot remove S: triage
@gir-bot add T: enhancement

@gir-bot gir-bot added T: enhancement Enhancement. and removed S: triage Issue needs triage. labels Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants