You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It takes about 115mS per secret to read from the vault. I suspect this is due to spawning a worker process for each line of the secrets file.
A comparable golang process reads 30 secrets in about 230mS. vault-env takes about 7-10 seconds to do the same thing.
When dealing with a large number of secrets, the performance impact is noticeable, especially when having frequent restarts of the node service during development.
I wanted to make you aware of this, I'll be attempting a fork and patch to correct this problem.
The text was updated successfully, but these errors were encountered:
Hi @netik! I've only ever used this library to load a handful of secrets, but I'm glad to hear you've gotten some use out of it at a larger scale. You're right that it would be much faster to hit vault directly. I'd be happy to merge a PR. Let me know if you need any help.
It takes about 115mS per secret to read from the vault. I suspect this is due to spawning a worker process for each line of the secrets file.
A comparable golang process reads 30 secrets in about 230mS. vault-env takes about 7-10 seconds to do the same thing.
When dealing with a large number of secrets, the performance impact is noticeable, especially when having frequent restarts of the node service during development.
I wanted to make you aware of this, I'll be attempting a fork and patch to correct this problem.
The text was updated successfully, but these errors were encountered: