Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is extremely slow when talking to vault. #4

Open
netik opened this issue Mar 27, 2020 · 1 comment
Open

Code is extremely slow when talking to vault. #4

netik opened this issue Mar 27, 2020 · 1 comment

Comments

@netik
Copy link

netik commented Mar 27, 2020

It takes about 115mS per secret to read from the vault. I suspect this is due to spawning a worker process for each line of the secrets file.

A comparable golang process reads 30 secrets in about 230mS. vault-env takes about 7-10 seconds to do the same thing.

When dealing with a large number of secrets, the performance impact is noticeable, especially when having frequent restarts of the node service during development.

I wanted to make you aware of this, I'll be attempting a fork and patch to correct this problem.

@summer4096
Copy link
Contributor

Hi @netik! I've only ever used this library to load a handful of secrets, but I'm glad to hear you've gotten some use out of it at a larger scale. You're right that it would be much faster to hit vault directly. I'd be happy to merge a PR. Let me know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants