Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync w Upstream Magritte #3564

Closed
seandenigris opened this issue Jan 18, 2024 · 4 comments
Closed

Sync w Upstream Magritte #3564

seandenigris opened this issue Jan 18, 2024 · 4 comments
Assignees
Milestone

Comments

@seandenigris
Copy link
Contributor

seandenigris commented Jan 18, 2024

The upstream repo merged an important fix RE mementos. In some cases forms were failing validation due to nonexistent conflicts. It’s also possible that copies of objects could be saved instead of the actual objects

@chisandrei
Copy link
Member

chisandrei commented Jan 19, 2024

Made feenkcom/magritte#3. I think first we'll sync the master branches and then merge the master branch into the feenk branch

@JurajKubelka
Copy link
Member

I think the upstream changes have been merged to GToolkit.
I created a magritte-metamodel/magritte#348 to push GToolkit changes into the upstream.

@JurajKubelka JurajKubelka self-assigned this Jan 22, 2024
@JurajKubelka JurajKubelka added this to the v1.0 milestone Jan 22, 2024
@svenvc
Copy link
Contributor

svenvc commented Jan 24, 2024

This could be closed then ?

@JurajKubelka
Copy link
Member

It could. I am waiting for the magritte-metamodel/magritte#348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants