Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http client in datamuse_api_client.dart is never closed. #10

Open
Luckey-Elijah opened this issue Dec 27, 2021 · 0 comments
Open

Http client in datamuse_api_client.dart is never closed. #10

Luckey-Elijah opened this issue Dec 27, 2021 · 0 comments

Comments

@Luckey-Elijah
Copy link

The http client created is never closed in datamuse_api_client.dart#L33. As per the http package docs:

It's important to close each client when it's done being used; failing to do so can cause the Dart process to hang.

Perhaps it's not a "serious" issue with a single un-closed client, such as this example project. But would something like this become an issue as a project scales?

@Luckey-Elijah Luckey-Elijah changed the title Http client in datamuse_api_client.dart is never disposed. Http client in datamuse_api_client.dart is never closed. Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant