Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases are triggered by code review #469

Closed
BigLep opened this issue Jul 11, 2024 · 3 comments
Closed

Releases are triggered by code review #469

BigLep opened this issue Jul 11, 2024 · 3 comments

Comments

@BigLep
Copy link
Member

BigLep commented Jul 11, 2024

Done Criteria

  1. The release steps outlined in https://github.com/filecoin-project/filecoin-ffi#release-process can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.
  2. The release description should be populated with the GitHub-generated release notes. (This repo doesn't have an accurate/updated CHANGELOG).

Why Important

The release process in https://github.com/filecoin-project/filecoin-ffi#release-process doesn't have any peer review. Mistakes can get made. Mistagging has happened in the past and can't be reverted. This is usually fixed by just doing another release, but this adds unnecessary confusion.

User/Customer

Maintainers

Notes

  1. Releases should also be clear and not have a duplicate asset-dedicated release.
@BigLep BigLep added this to FilOz Jul 11, 2024
@BigLep BigLep moved this to 🔎 In review in FilOz Jul 23, 2024
@BigLep
Copy link
Member Author

BigLep commented Jul 23, 2024

This is being addressed by #473

@BigLep
Copy link
Member Author

BigLep commented Aug 1, 2024

Now the work is in #475

@rjan90
Copy link
Contributor

rjan90 commented Sep 30, 2024

Closing as completed since: #475 has been merged, and we also fixed some follow-ups:

A full release triggered by code-review was shipped here: #493

@rjan90 rjan90 closed this as completed Sep 30, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in FilOz Sep 30, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

2 participants