Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to integrate the robots_txt package. #113

Open
vxern opened this issue Jan 9, 2023 · 3 comments
Open

Proposal to integrate the robots_txt package. #113

vxern opened this issue Jan 9, 2023 · 3 comments

Comments

@vxern
Copy link

vxern commented Jan 9, 2023

Hi, author of the robots_txt package here. I thought that, since linkcheck currently features its own implementation of a parser for robots.txt, it would be a good idea to instead depend on something more complete, tested and documented.

@filiph
Copy link
Owner

filiph commented Jan 9, 2023

Thanks for the suggestion, @vxern! I'm afraid I don't have the time to implement this. Are you suggesting you'd implement this as well?

Also, cc @parlough for his opinion.

@vxern
Copy link
Author

vxern commented Jan 9, 2023

Hi, @filiph. Sure, I wouldn't mind. Let's wait for parlough's opinion first, though. :)

@parlough
Copy link
Collaborator

parlough commented Jan 10, 2023

Sounds good to me, but it's a bit hard to determine for sure without seeing what the end result would look like.

I'd be happy to take a look if you open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants