You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example, the volume directory is included in this list, but its Makefile does not contain an integ-test rule, resulting in failure. The integration test(s) for volume live under the snapshotter directory.
Is there a reason why volume integ tests are under snapshotter ? If there is, we can just add a no-op integ-test rule to the volume Makefile. If not, maybe we can refactor to just pull that test into the volume directory.
e: answering the above question: volume is provided as a package and consumed in the volume integ test. moving this test to the volume dir would introduce an import cycle.
The text was updated successfully, but these errors were encountered:
Right now the top level Makefile uses a list of sub-directories to target running integration tests:
firecracker-containerd/Makefile
Lines 14 to 16 in 279a03c
For example, the
volume
directory is included in this list, but its Makefile does not contain aninteg-test
rule, resulting in failure. The integration test(s) for volume live under thesnapshotter
directory.Is there a reason why volume integ tests are under
snapshotter
? If there is, we can just add a no-opinteg-test
rule to the volume Makefile. If not, maybe we can refactor to just pull that test into the volume directory.e: answering the above question: volume is provided as a package and consumed in the volume integ test. moving this test to the volume dir would introduce an import cycle.
The text was updated successfully, but these errors were encountered: