Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume subdir has no integ-test Makefile rule #701

Open
ginglis13 opened this issue Aug 30, 2022 · 0 comments
Open

volume subdir has no integ-test Makefile rule #701

ginglis13 opened this issue Aug 30, 2022 · 0 comments

Comments

@ginglis13
Copy link
Contributor

ginglis13 commented Aug 30, 2022

Right now the top level Makefile uses a list of sub-directories to target running integration tests:

SUBDIRS:=agent runtime examples firecracker-control/cmd/containerd snapshotter docker-credential-mmds volume
TEST_SUBDIRS:=$(addprefix test-,$(SUBDIRS))
INTEG_TEST_SUBDIRS:=$(addprefix integ-test-,$(SUBDIRS))

For example, the volume directory is included in this list, but its Makefile does not contain an integ-test rule, resulting in failure. The integration test(s) for volume live under the snapshotter directory.

Is there a reason why volume integ tests are under snapshotter ? If there is, we can just add a no-op integ-test rule to the volume Makefile. If not, maybe we can refactor to just pull that test into the volume directory.

e: answering the above question: volume is provided as a package and consumed in the volume integ test. moving this test to the volume dir would introduce an import cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant