From 69d86e0eecbe415ba4609ef0081a152ac0077696 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pablo=20Barb=C3=A1chano?= Date: Tue, 17 Dec 2024 14:52:45 +0100 Subject: [PATCH 1/2] ci: allow passing a dict/list as a step parameter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In some cases we may want to pass a complex value to a step. For example: .buildkite/pipeline_pr.py \ --step-param 'retry/automatic=[{"exit_status": "*", "limit": 2}]' Signed-off-by: Pablo Barbáchano --- .buildkite/common.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.buildkite/common.py b/.buildkite/common.py index a8913d5d6ef..342bd671ddc 100644 --- a/.buildkite/common.py +++ b/.buildkite/common.py @@ -6,6 +6,7 @@ """ import argparse +import ast import json import os import random @@ -138,7 +139,7 @@ def __call__(self, parser, namespace, value, option_string=None): res = getattr(namespace, self.dest, {}) key_str, val = value.split("=", maxsplit=1) keys = key_str.split("/") - update = {keys[-1]: val} + update = {keys[-1]: ast.literal_eval(val)} for key in list(reversed(keys))[1:]: update = {key: update} res = overlay_dict(res, update) From b383afcb81fb0c120814ee3feeb01f89804e9dd4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pablo=20Barb=C3=A1chano?= Date: Tue, 17 Dec 2024 16:09:56 +0100 Subject: [PATCH 2/2] ci: report all microcode packages during a test run MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit microcode_ctl only covers Intel firmware files. Capture AMD and any other possible ones. Signed-off-by: Pablo Barbáchano --- tools/devtool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/devtool b/tools/devtool index 7d41229b2e7..a55fda81269 100755 --- a/tools/devtool +++ b/tools/devtool @@ -742,7 +742,7 @@ cmd_test() { # If we got to here, we've got all we need to continue. say "Kernel version: $(uname -r)" say "$(sed '/^processor.*: 0$/,/^processor.*: 1$/!d; /^processor.*: 1$/d' /proc/cpuinfo)" - say "RPM microcode_ctl version: $(rpm -q microcode_ctl)" + say "RPM firmware versions: $(rpm -q microcode_ctl amd-ucode-firmware linux-firmware)" env |grep -P "^(AWS_EMF_|BUILDKITE|CODECOV_)" > env.list if [[ $performance_tweaks -eq 1 ]]; then