Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring LiveBuilder durations #221

Open
liamaharon opened this issue Oct 21, 2024 · 2 comments
Open

Allow configuring LiveBuilder durations #221

liamaharon opened this issue Oct 21, 2024 · 2 comments

Comments

@liamaharon
Copy link
Contributor

/// Time the proposer have to propose a block from the beginning of the slot (https://www.paradigm.xyz/2023/04/mev-boost-ethereum-consensus Slot anatomy)
const SLOT_PROPOSAL_DURATION: std::time::Duration = Duration::from_secs(4);
/// Delta from slot time to get_header dead line. If we can't get the block header before slot_time + BLOCK_HEADER_DEAD_LINE_DELTA we cancel the slot.
/// Careful: It's signed and usually negative since we need de header BEFORE the slot time.
const BLOCK_HEADER_DEAD_LINE_DELTA: time::Duration = time::Duration::milliseconds(-2500);
/// Polling period while trying to get a block header
const GET_BLOCK_HEADER_PERIOD: time::Duration = time::Duration::milliseconds(250);

are hard coded assuming mainnet block times, they need to be adjusted for shorter L2 block time intervals.

@liamaharon liamaharon changed the title Allow configuring LiveBuilder duration constants Allow configuring LiveBuilder durations Oct 21, 2024
@ZanCorDX
Copy link
Contributor

It's definitely useful to have this configurable for L2 but I would not go all the way to the config file. SLOT_PROPOSAL_DURATION is part of the protocol I wouldn't let the user change this value.

@0xmichalis
Copy link
Contributor

This is fixed by #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants