You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There appears to be a memory use regression in v1.48.1, which is presumably a result of the disposeContext behavior here.
When attempting to run serverless package locally there is a pause of several minutes on a fairly large serverless project with around 30 fns. After the pause bundles start being emitted and the build continues as normal. This issue does not exist on the immediately preceding version, v1.48.0 or any version tested before that, back to v1.43.0. Multiple version of esbuild between v0.17.3 and v0.19.12 have been tested, and multiple relatively recent versions of serverless
More important than the performance regression is that during this pause, in GitHub Actions CI on a custom 4 CPU runner the process fails entirely, with what is clearly an OOM.
Error:
Error: The service was stopped
at /home/runner/work/takeshape/takeshape/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1100:28
at responseCallbacks.<computed> (/home/runner/work/takeshape/takeshape/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:697:9)
at Socket.afterClose (/home/runner/work/takeshape/takeshape/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:687:28)
at Socket.emit (node:events:530:35)
at Socket.emit (node:domain:488:12)
at endReadableNT (node:internal/streams/readable:1696:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
To Reproduce
Create a large project, with 100s of dependencies including aws-sdk, etc., being bundled in.
Install v1.48.1 or later of this plugin.
Configure this plugin to logLevel: info.
Run serverless package.
Note the extended wait before bundles are emitted.
Attempt to run in GitHub Actions. Note that the process will fail with little info.
Expected behavior
On earlier versions there is not the extended wait, nor does this fail in CI.
Versions (please complete the following information):
Describe the bug
There appears to be a memory use regression in v1.48.1, which is presumably a result of the
disposeContext
behavior here.When attempting to run
serverless package
locally there is a pause of several minutes on a fairly large serverless project with around 30 fns. After the pause bundles start being emitted and the build continues as normal. This issue does not exist on the immediately preceding version, v1.48.0 or any version tested before that, back to v1.43.0. Multiple version ofesbuild
between v0.17.3 and v0.19.12 have been tested, and multiple relatively recent versions ofserverless
More important than the performance regression is that during this pause, in GitHub Actions CI on a custom 4 CPU runner the process fails entirely, with what is clearly an OOM.
To Reproduce
aws-sdk
, etc., being bundled in.v1.48.1
or later of this plugin.logLevel: info
.serverless package
.Expected behavior
On earlier versions there is not the extended wait, nor does this fail in CI.
Versions (please complete the following information):
Additional context
Have also tried different concurrency settings (1, 2, 3, 4) with no change.
Here is a pared down config that has the issue for me:
The text was updated successfully, but these errors were encountered: