We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think if requests are uncomfortable enough that we have to have this in tests: https://github.com/fog/fog-google/blob/23878b2d33ea1aecb54fa7d4652b1c77b3e51530/test/helpers/client_helper.rb#L43-L75 , we should just make requests return an operation object we can just use .wait_for on.
.wait_for
So instead of:
request = @client.insert_backup_run(instance.name, data) operation = @operations.new(:service => service).get(request.name) operation.wait_for { ready? }
, we should have something like:
operation = @client.insert_backup_run(instance.name, data) operation.wait_for { ready? }
@icco WDYT? Or am I missing something?
The text was updated successfully, but these errors were encountered:
Closing in favor of #381
Sorry, something went wrong.
Temikus
No branches or pull requests
I think if requests are uncomfortable enough that we have to have this in tests:
https://github.com/fog/fog-google/blob/23878b2d33ea1aecb54fa7d4652b1c77b3e51530/test/helpers/client_helper.rb#L43-L75
, we should just make requests return an operation object we can just use
.wait_for
on.So instead of:
, we should have something like:
@icco WDYT? Or am I missing something?
The text was updated successfully, but these errors were encountered: