ci: Use Nix for obtaining dependencies #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jtojnar
force-pushed
the
nix-ci
branch
5 times, most recently
from
467c828 to
e5ef5a8
Compare
jtojnar
changed the title
jtojnar
force-pushed
the
nix-ci
branch
6 times, most recently
from
a37e9cd to
2b2b7dd
Compare
I added `packageOverrides` argument to `php` package in nixpkgs, allowing us to simplify the php definitions a lot.
This will allow us to run integration test and create-zipball script reproducibly.
Previously we were installing - PHP using Travis’s built-in mechanism that downloads distributions-specific tarballs (PHP 7.1 is not compatible with focal), - Composer using itself, - Python using pyenv (quite slow), - Python libraries using pip, - Node using nvm, - jq using apt, - PHP dependencies using Composer, - client-side dependencies using npm. Switching to Nix will allow us to get rid of all except the last two methods and achieve fully reproducible environment across both CI and developers’ machines. The travis config is based on https://github.com/cachix/travis-ci-example. Also allows us to switch distribution to focal. Additionally, I had to add shebang to bump-version.js and make it executable since npm run does not seem to set $NODE any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were installing
Switching to Nix will allow us to get rid of all except the last two methods and achieve fully reproducible environment across both CI and developers’ machines.
The travis config is based on https://github.com/cachix/travis-ci-example.
Also allows us to switch distribution to focal.