Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to every request #161

Closed
mlissner opened this issue Sep 30, 2016 · 0 comments
Closed

Add timeouts to every request #161

mlissner opened this issue Sep 30, 2016 · 0 comments

Comments

@mlissner
Copy link
Member

An anti-feature of the super-popular requests library is that it doesn't have timeouts by default. This means that if a connection hangs for whatever reason, the program itself will hang...forever.

I filed https://github.com/kennethreitz/requests/issues/3070 about changing this in the next major version of requests, but until then, we need to add timeout values to every request. I think two of the Texas scrapers in #160 are currently frozen for just this reason.

I'll be pushing a release with this fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant