Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executeActionsEmail #72

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add executeActionsEmail #72

merged 3 commits into from
Oct 3, 2023

Conversation

jprw10
Copy link
Contributor

@jprw10 jprw10 commented Sep 28, 2023

No description provided.

@fschmtt fschmtt self-requested a review September 28, 2023 20:29
@fschmtt
Copy link
Owner

fschmtt commented Oct 2, 2023

Hi, thanks for your contribution 🥳

Do you mind adding some unit and integration test for this new endpoint?

There are a lot of examples already - let me know if I can assist you 😄

@jprw10
Copy link
Contributor Author

jprw10 commented Oct 2, 2023

Hello!

I didn't add any unit or integration test because the endpoint is only sending a mail to specified user, basically there's nothing to test

Do you want me to add tests anyway?

@fschmtt
Copy link
Owner

fschmtt commented Oct 2, 2023

Yeah would be nice if you could add them:

  • The unit test makes sure there's no unwanted & undetected change.
  • The integration tests are run against all Keycloak versions since 13.0.0 and ensure that they work with every version.

Thank you 😄

tests/Integration/Resource/UsersTest.php Outdated Show resolved Hide resolved
tests/Unit/Resource/UsersTest.php Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@242fc4d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage        ?   96.10%           
=======================================
  Files           ?       35           
  Lines           ?      795           
  Branches        ?        0           
=======================================
  Hits            ?      764           
  Misses          ?       31           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschmtt fschmtt merged commit 01c0dd9 into fschmtt:main Oct 3, 2023
16 checks passed
@fschmtt
Copy link
Owner

fschmtt commented Oct 3, 2023

Thanks again, use 0.15.0 to use your changes 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants