Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XPlot.Plotly: Chart.WithOptions and Chart.WithLayout do the same thing #81

Open
FoggyFinder opened this issue Nov 12, 2018 · 1 comment
Open

XPlot.Plotly: Chart.WithOptions and Chart.WithLayout do the same thing #81

FoggyFinder opened this issue Nov 12, 2018 · 1 comment
Labels
Area: API Area: plotly enhancement help wanted

Comments

@FoggyFinder
Copy link

It seems like WithOptions and WithLayout are the same:

member __.WithOptions options = __.WithLayout options

Probably it will be better to remove WithOptions or make it obsolete to avoid confusing.
@cartermp
Copy link
Collaborator

cartermp commented Nov 8, 2019

Just to have some API consistency I think WithLayout is better to deprecate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: API Area: plotly enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cartermp @FoggyFinder