Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart does not re-render when dataSource is updated #7

Open
joelmukuthu opened this issue Oct 23, 2020 · 0 comments
Open

Chart does not re-render when dataSource is updated #7

joelmukuthu opened this issue Oct 23, 2020 · 0 comments

Comments

@joelmukuthu
Copy link

Hi, thanks for this module. I tried live-updating the data but it doesn't seem to work. I've traced it down and found that isDataSourceUpdated doesn't detect changes in the data.

It seems to me that that method could be simplified to compare the values of dataSource._data instead of the whole object. I can send a PR for that if you think that's the way to go? Otherwise let me know if I can help debug/reproduce this.

Thanks,
Joel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant