Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logsumexp #5

Open
edgarriba opened this issue Mar 30, 2020 · 1 comment
Open

update logsumexp #5

edgarriba opened this issue Mar 30, 2020 · 1 comment

Comments

@edgarriba
Copy link

hi @fwilliams,

in recent pytorch versions it has been introduced torch.logsumexp which I think that could be used to replace stabilized_log_sum_exp in your implementation of the sinkhorn algorithm.

found this throw: https://github.com/magicleap/SuperGluePretrainedNetwork/blob/master/models/superglue.py#L143-L172
@fwilliams
Copy link
Owner

Thanks for the pointer! I wrote this during a project in 2018 and didn't know this function was available. I'll update this in the next version of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fwilliams @edgarriba