Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics with unicode, handling meta events and stopping #22

Open
manojmo opened this issue Sep 11, 2016 · 0 comments
Open

Lyrics with unicode, handling meta events and stopping #22

manojmo opened this issue Sep 11, 2016 · 0 comments

Comments

@manojmo
Copy link

manojmo commented Sep 11, 2016

hi,
firstly, thanks for this nice framework.

i wanted to also display lyrics in devnagari(indian script) and found that currently it won't work as it is,
due to the x-user-defined charset. so i had to add some conversion code. i also tried another approach with a different version of loadRemote() in index.html, using the arrayBuffer type. then i had to change stream.js accordingly, which i have saved as stream1.js. i think this is a better approach, as to-from encoding conversions are reduced. the "b102_Bhairavi_*.mid file i have used is the test-file for unicode lyrics.
Of course we also need to read and propagate lyrics events in replayer, and i have done it using the handleMidiMetaEvent().

i have also added a stop button by calling the audioplayer.stop().it works, but i wonder if some other clean-up needs to be done.

have attached my change files to this issue.

regards,
manoj

jasmid_fix.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant