update etcd dependency #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in the fix for an issue that could cause the etcd client to use an incorrect revision when re-starting a watch after an etcd server failure. This presented as a crash in production due to receiving a watch event with a revision equal to (not greater) than the last processed revision. It was difficult to follow the discussion in the etcd issues, but this comment sums it up nicely: etcd-io/etcd#15248 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the fix for an issue that could cause the etcd client to use an incorrect revision when re-starting a watch after an etcd server failure. This presented as a crash in production due to receiving a watch event with a revision equal to (not greater) than the last processed revision. It was difficult to follow the discussion in the etcd issues, but this comment sums it up nicely:
etcd-io/etcd#15248 (comment)
This change is