Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gefyra-run: support for --cpu/--memory and similar parameters #742

Open
crkurz opened this issue Nov 5, 2024 · 0 comments
Open

gefyra-run: support for --cpu/--memory and similar parameters #742

crkurz opened this issue Nov 5, 2024 · 0 comments
Labels
enhancement 🎉 New feature or request good first issue ✨ Good for newcomers python Pull requests that update Python code

Comments

@crkurz
Copy link

crkurz commented Nov 5, 2024

What is the new feature about?

gefyra-run starts local containers with no constraints on cpu or memory usage. This means that any such container by default can consume unlimited cpu and memory and thus can make the entire docker host (with all other containers/services) unresponsive.

The other problem is that cpu/memory problems may stay undiscovered in gefyra until they get deployed in production.

It is good practice to put cpu/memory constraints on containers, in particular when running sets of containers.

cli option ideas:

  • add options like --cpu <value>, --memory <value> and similar parameters
  • or even --cpu-from <pod/deployment>, --memory-from <pod/deployment>
  • or generic design approach: --apply-container-settings-from :<pod/deployment>; e.g. , --apply-container-settings-from cpu,memory:my-pod

Why would such a feature be important to you?

  • mitigate risk of one container bringing down the entire dev machine
  • find cpu/mem issues early during dev (with gefyra)

Anything else we need to know?

No response

@SteinRobert SteinRobert added enhancement 🎉 New feature or request good first issue ✨ Good for newcomers python Pull requests that update Python code labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎉 New feature or request good first issue ✨ Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants