Update db-xrefs.yaml for additional COG entries #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2374
Additional hints from #2374 (comment)
@pgaudet That said, I'm not sure the COG_Pathway entry makes sense any longer. For example, looking at https://www.ncbi.nlm.nih.gov/research/cog/pathway/Na+-translocating%20Fd:NADH%20oxidoreductase/, I'm not sure that there is a real identifier in there:
COG_Pathway:Na+-translocating%20Fd:NADH%20oxidoreductaseseems wrong.That said, "updating" here for
COG_Pathwaymakes us no more wrong, but we might want explore this a little if we actually have xrefs that we need to link.