Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GO-CAM stats #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add GO-CAM stats #18

wants to merge 3 commits into from

Conversation

dustine32
Copy link

@dustine32 dustine32 commented Sep 9, 2021

For geneontology/go-site#1180.

Remaining issues to solve before merging:

  • Parameterize blazegraph_url for triplestore created in Jenkins context similar to golrurl param. Likely will be localhost-something? Tagging @kltm.
  • networkx error (shown below) was occuring when using networkx==1.11 as previously specified in requirements.txt. I upped this to 2.2 to match version installed in Jenkins go-stats stage and the error was fixed.
  • How to handle the new gocams fields not appearing in the previous go-stats.json accessed from curent.geneontology.org? On the first run with this change, this field being omitted will break go-stats in several places. We might need to coordinate merging this PR with the data being "updated" on current?

The networkx error mentioned above:

File "/Users/ebertdu/go/go-stats/libraries/go-stats/obo_parser.py", line 462, in get_term
    return self.obo_graph.nodes[query]['object']
TypeError: 'method' object is not subscriptable

Edit: change numbered list to checkboxes.

@dustine32 dustine32 requested a review from lpalbou September 9, 2021 06:28
@kltm
Copy link
Member

kltm commented Sep 9, 2021

@dustine32 I think I'm maybe not understanding the complete context of what's going on here--I had thought we had wrapped up go-stats work?
In general, parameters are "good". what the blazegraph_url would be set to would depend on where you're using it. If inside a docker image, that would likely be localhost:XYX or something (probably in the Jenkinsfile). If you're interested in an external context, that would be the public URL.

@dustine32
Copy link
Author

@kltm This request for adding some simple GO-CAM stats came out of the Alliance pathways call discussing geneontology/noctua#736. Actually, sorry, I realize now we didn't really prioritize this work other than just trying to get something in before @lpalbou's last day. We can decide when to continue the work of getting the change into the GO pipeline later.

@lpalbou
Copy link
Contributor

lpalbou commented Sep 9, 2021

@kltm for a little bit of context, this has indeed nothing to do with the handover of the GO stats, except maybe giving some training / understanding of the code to @dustine32 . However, we had a request last week from Helen and the Alliance Pathway group, following the issues we had with the last GO release where some GO-CAMs were missing geneontology/noctua#736. It was then proposed to add a simple stats about GO-CAMs to make sure that prior to a release, the number would not be too different, or at least could be double checked by Pascale or QA team.

@dustine32
Copy link
Author

I just added a method to fill in zero values when gocams stats are not in previous stats during comparison. This solves the third issue from above: the first run of these go-stats with the new gocams fields will be missing these fields in the previous go-stats.json on current.geneontology.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants